Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing scroll-to-top on mobile devices #1851

Closed
5 tasks
waridrox opened this issue Mar 16, 2021 · 5 comments · Fixed by #1852
Closed
5 tasks

Removing scroll-to-top on mobile devices #1851

waridrox opened this issue Mar 16, 2021 · 5 comments · Fixed by #1852

Comments

@waridrox
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Currently the scroll-to-top button on the image-sequencer shows up in mobile-view whose functionality is to bring the user to top of the webpage.
    On mobile devices, the scroll-to-top button gets in the way while interacting with the webpage thereby leading to bad user-experience.
    We want this feature to be removed from the mobile-view as the mobile screens have limited screen area to begin with and nowadays swipe gesture can take care of that efficiently.

Screenshot 2021-03-16 at 9 50 50 PM

.Update the file demo.css in the publiclab/image-sequencer/blob/main/examples/demo.css repository (press the little pen Icon) and edit the line as shown below.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

#move-up {
position: fixed;
bottom: 50px;
right: 40px;
z-index: 550;
display: none;
background:transparent;
border:none;
}
#move-up i {
font-size:60px;
opacity:0.7;
color:#BABABA;
}

#move-up { 
  position: fixed; 
- bottom: 50px; 
+ bottom: 30px;
- right: 40px; 
+ right: 20px;
  z-index: 550; 
  display: none; 
  background:transparent; 
  border:none; 
} 
 
#move-up i { 
- font-size:60px; 
+ font-size:50px;
  opacity:0.7; 
  color:#BABABA; 
} 

+ @media (max-width: 768px), (max-height 700px) {
+ #move-up {
+           display: none !important; /* !important is used to override the jQuery style */
+ }
+}
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@waridrox
Copy link
Member Author

@jywarren @cesswairimu Kindly add the fto label :)

@harshkhandeparkar
Copy link
Member

If another reviewer/maintainer approves this, they can add the first-timers-only label :)

@jcads
Copy link

jcads commented Mar 16, 2021

Can I work on this one?

@harshkhandeparkar
Copy link
Member

Go ahead! 🚀

@jywarren
Copy link
Member

Thank you @waridrox for creating this and @jcads for taking it up!!! And @harshkhandeparkar for supporting!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants