Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get module speed benchmarks to appear in a PR comment #971

Open
jywarren opened this issue Apr 1, 2019 · 1 comment
Open

Get module speed benchmarks to appear in a PR comment #971

jywarren opened this issue Apr 1, 2019 · 1 comment

Comments

@jywarren
Copy link
Member

jywarren commented Apr 1, 2019

We could use https://danger.systems/js/ to collect the benchmark times and add them to each PR so you can easily read them. We could use the HTML <details> element to hide them unless you want to see them:

<details>
    <summary>馃搳 Benchmarks (click to expand)</summary>
    <p>Benchmarks are run on each module</p>
    <ul>
      <li><b>Average</b>: 341ms</li>
      <li><b>Blur</b>: 441ms</li>
      <li><b>Blend</b>: 141ms</li>
      <!-- ... -->
    </ul>
</details>

This would be pretty neat! We could also actually eventually output test image outputs that could be visually reviewed.

@vibhorgupta-gh
Copy link

Related to #780
WIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants