Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete location_tags.js #11

Closed
jywarren opened this issue Jun 15, 2017 · 2 comments
Closed

Delete location_tags.js #11

jywarren opened this issue Jun 15, 2017 · 2 comments
Assignees
Milestone

Comments

@jywarren
Copy link
Member

jywarren commented Jun 15, 2017

I think this may need to be our next project -- to break this up properly and do a similar creation of an object around this --

https://github.com/publiclab/leaflet-blurred-location/blob/master/src/core/location_tags.js

For example, line 8 could be a named function stored in another file and require()'ed in, as could line 21.

We can do this one PR at a time, and of course after #7 is merged. Just taking good notes!

@jywarren
Copy link
Member Author

@mridulnagpal can you tackle this next? See how we can do this one step at a time? So if you do multiple things, please open separate PRs so we can review each change one at a time.

@jywarren jywarren added this to the Basic setup milestone Jun 16, 2017
@jywarren
Copy link
Member Author

I looked over this and actually i'm not convinced there's any code in there that we need! We're redoing all of that! So -- changing the title -- let's delete it!

@jywarren jywarren self-assigned this Jun 16, 2017
@jywarren jywarren changed the title Break up and reformat location_tags.js Delete location_tags.js Jun 16, 2017
@jywarren jywarren modified the milestone: Basic setup Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants