Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a badge on layer button to show number of active layers #201

Open
sagarpreet-chadha opened this issue Jun 10, 2019 · 6 comments 路 May be fixed by #269
Open

Add a badge on layer button to show number of active layers #201

sagarpreet-chadha opened this issue Jun 10, 2019 · 6 comments 路 May be fixed by #269
Labels
enhancement New feature or request
Milestone
v1.1

Comments

@sagarpreet-chadha
Copy link
Collaborator

The title is self explainatory . Adding prototype soon here 馃槃 .
@ananyaarun ananyaarun added the enhancement New feature or request label Jun 26, 2019
@jywarren jywarren added this to the v1.0 milestone Jul 8, 2019
@jywarren jywarren modified the milestones: v1.0, v1.1 Sep 4, 2019
@crisner
Copy link
Contributor

crisner commented Oct 12, 2019

I would like to give this one a try. Can I work on this @sagarpreet-chadha ? May I know what kind of style you have in mind for the badge? Is it supposed to be displayed next to the 'Turn on layers' text on the leaflet control?

@sagarpreet-chadha
Copy link
Collaborator Author

Yes please.
Have you seen whatsapp app --- the small badge that appears on contact tab that displays number of unread chats.

@crisner
Copy link
Contributor

crisner commented Oct 12, 2019

Yes. A green circle displaying the number. What color do we use here for the circle?

@crisner
Copy link
Contributor

crisner commented Oct 12, 2019 •
edited
Loading

How about something between grey(leaflet control's border color) and the text color with the numbers in white?

@sagarpreet-chadha
Copy link
Collaborator Author

I guess you can start writing the CSS and JS to change number in the circle .
Later we can ask @ebarry to chime in and tell the color combination . Thanks!

@crisner
Copy link
Contributor

crisner commented Oct 12, 2019

Okay 馃憤

@crisner crisner linked a pull request Oct 13, 2019 that will close this issue
Open
5 tasks
@crisner crisner mentioned this issue Dec 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Show number of active layers on a badge crisner/leaflet-environmental-layers
4 participants
@jywarren @sagarpreet-chadha @crisner @ananyaarun