Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML links on Publiclab comments overflows on mobile screen #11061

Closed
1 of 5 tasks
Forchapeatl opened this issue Apr 16, 2022 · 7 comments · Fixed by #11062
Closed
1 of 5 tasks

HTML links on Publiclab comments overflows on mobile screen #11061

Forchapeatl opened this issue Apr 16, 2022 · 7 comments · Fixed by #11062
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Forchapeatl
Copy link
Contributor

image

💡Format this Issue Into a First Timers Issue

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting✍️, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled🏷. Or, if this is not your first time, try to solve it yourself🧑‍💻!


Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

        <div <% unless @node.has_tag('style:wide') %>style="max-width:800px;
+  word-wrap: break-word;"<% end %> id="content" class="pl-content wiki">
          <% if @node.has_tag('format:raw') %>
            <%= raw @revision.render_body_raw %>
          <% else %>
            <%= raw auto_link(insert_extras(@revision.render_body), sanitize: false) %>
          <% end %>
        </div>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@Forchapeatl Forchapeatl added the fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet label Apr 16, 2022
@fetian-debug
Copy link
Contributor

Hi @Forchapeatl @TildaDares, Please kindly review. Thank you!

@Forchapeatl
Copy link
Contributor Author

Forchapeatl commented Apr 16, 2022

Hi @Forchapeatl @TildaDares, Please kindly review. Thank you!

Hello @fetian-debug , I am not a mentor. If you wish to work on this issue, please address this message to @TildaDares

@Forchapeatl Forchapeatl changed the title HTML links overflows on mobile screen HTML links on Publiclab comments overflows on mobile screen Apr 17, 2022
@TildaDares
Copy link
Member

Hi @Forchapeatl, can you send me the link to the page that has this bug? Thanks!!

@Forchapeatl
Copy link
Contributor Author

Hi @Forchapeatl, can you send me the link to the page that has this bug? Thanks!!

Hello @TildaDares https://publiclab.org/wiki/location-privacy

@TildaDares
Copy link
Member

Looks good @Forchapeatl. Thank you!!

@TildaDares TildaDares added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. and removed fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet labels Apr 18, 2022
@abhishekchauhan15
Copy link
Contributor

@TildaDares I have fixed this issue can you please review it.

@TildaDares
Copy link
Member

TildaDares commented Apr 18, 2022

Hi @abhishekchauhan15, contributors are allowed to work on only one FTO. Also, @fetian-debug has already claimed this issue. Thanks!!

@TildaDares TildaDares linked a pull request Apr 21, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
4 participants