Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale pages listing ( fixes #1929 ) #1957

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

Mujadded
Copy link
Contributor

@Mujadded Mujadded commented Jan 11, 2018

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

commit 30f5308
Merge: a4509ee 91a6a83
Author: mujadded <mujadded.alif@gmail.com>
Date:   Thu Jan 11 11:39:01 2018 +0000

    merged with master

commit a4509ee
Author: mujadded <mujadded.alif@gmail.com>
Date:   Thu Jan 11 11:31:48 2018 +0000

    spec added and routes changed

commit a5345a9
Author: Mujadded <mujadded.alif@welltravel.com>
Date:   Thu Jan 11 13:21:11 2018 +0600

    Stale page added in controller

commit 91a6a83
Author: Mujadded <mujadded.alif@welltravel.com>
Date:   Thu Jan 11 13:21:11 2018 +0600

    Stale page added in controller
@PublicLabBot
Copy link

3 Messages
📖 @Mujadded Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the body of your PR, in the format: Fixes #123.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@Mujadded Mujadded changed the title Stale pages listing at /wiki/stale #1929 Stale pages listing #1929 Jan 11, 2018
@Mujadded Mujadded changed the title Stale pages listing #1929 Stale pages listing ( fixes #1929 ) Jan 11, 2018
@jywarren
Copy link
Member

Hey, this looks great. Thanks so much! This your first contribution to our project, right? Welcome!

Merging now. If you're looking for a new challenge, please take a look at our help-wanted list: https://github.com/publiclab/plots2/labels/help-wanted

Thanks again!

@jywarren jywarren merged commit 37ae7c9 into publiclab:master Jan 11, 2018
@Mujadded
Copy link
Contributor Author

@jywarren yes , this is my first contribution in this project infact this is my first contribution in github , thank you so much for giving me the opportunity 😃 . Yes i do want to contribute more, will search and claim another challenge very soon.

@jywarren
Copy link
Member

jywarren commented Jan 12, 2018 via email

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
commit 30f5308
Merge: a4509ee 91a6a83
Author: mujadded <mujadded.alif@gmail.com>
Date:   Thu Jan 11 11:39:01 2018 +0000

    merged with master

commit a4509ee
Author: mujadded <mujadded.alif@gmail.com>
Date:   Thu Jan 11 11:31:48 2018 +0000

    spec added and routes changed

commit a5345a9
Author: Mujadded <mujadded.alif@welltravel.com>
Date:   Thu Jan 11 13:21:11 2018 +0600

    Stale page added in controller

commit 91a6a83
Author: Mujadded <mujadded.alif@welltravel.com>
Date:   Thu Jan 11 13:21:11 2018 +0600

    Stale page added in controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants