Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system tests (rails 5.1+ feature) #3683

Closed
jywarren opened this issue Oct 12, 2018 · 3 comments
Closed

system tests (rails 5.1+ feature) #3683

jywarren opened this issue Oct 12, 2018 · 3 comments
Labels
testing issues are usually for adding unit tests, integration tests or any other tests for a feature

Comments

@jywarren
Copy link
Member

New testing framework in rails allows tests to take screenshots! But also cool form filling syntax:

https://chriskottom.com/blog/2017/04/full-stack-testing-with-rails-system-tests/
@grvsachdeva grvsachdeva added the testing issues are usually for adding unit tests, integration tests or any other tests for a feature label Oct 13, 2018
@jywarren jywarren mentioned this issue Jan 31, 2019
Closed
This was referenced Feb 27, 2019
Merged
Merged
@jywarren
Copy link
Member Author

Tried implementing this in #4888!

Also see https://guides.rubyonrails.org/testing.html#implementing-a-system-test

@jywarren
Copy link
Member Author

System tests will also help us merge @dependabot PRs of JS updates! Currently these have to be tested manually:

https://github.com/publiclab/plots2/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+label%3Ajavascript+label%3Adependencies

@jywarren
Copy link
Member Author

jywarren commented Mar 1, 2019

If we get this to work, we should test our inline maps using it, because they're turning out to be a bit fragile! https://publiclab.org/wiki/inline-maps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing issues are usually for adding unit tests, integration tests or any other tests for a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jywarren @grvsachdeva