Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow icon is not working in wiki section #4443

Closed
Rishabh-Kumar-Bothra opened this issue Dec 29, 2018 · 4 comments
Closed

follow icon is not working in wiki section #4443

Rishabh-Kumar-Bothra opened this issue Dec 29, 2018 · 4 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed

Comments

@Rishabh-Kumar-Bothra
Copy link
Contributor

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?
image

Follow icon is not working/responding

Please show us where to look

https://publiclab.org/wiki/comment-templates

What's your PublicLab.org username?

geekychaser

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@jywarren @gauravano follow button is not working but it looks all fine in code ?

@oorjitchowdhary
Copy link
Member

oorjitchowdhary commented Dec 29, 2018

Hi @geekychaser, there's an error in the code..
Looks like in the latest commit, someone has misplaced the <li> and <a> tags.

<li rel="tooltip" title="Follow" class="btn btn-default btn-sm" data-html="true" rel="popover" data-content="<%= "No tags" if tagnames.nil? || tagnames.length == 0 %><% if tagnames %><% tagnames.each do |tagname| %><p style='margin-bottom:3px;'><a href='/subscribe/tag/<%= tagname %>' class='btn btn-default btn-mini'><%= tagname %></a></p><% end %><% end %><hr /><i class='fa fa-user'></i><% if current_user && !current_user.following?(node.author.user) %>&nbsp;<a class='btn btn-sm' href='/relationships?followed_id=<%= node.author.id %>' data-method='post' > <%= node.author.name %></a><% else %><%= node.author.name %><% end %>" title="Follow by tag or author" data-placement="left">
<i class="fa fa-user-plus" aria-hidden="true"></i>
</li>

Are you willing to submit a fix for this?

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@oorjitchowdhary yes, let me check if there is misplaced tag or error is due to some unknown reason

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@oorjitchowdhary no there is no issue with <li> tag

@grvsachdeva grvsachdeva added the bug the issue is regarding one of our programs which faces problems when a certain task is executed label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed
Projects
None yet
Development

No branches or pull requests

3 participants