Make spamaway ids unique

[jywarren]

Our spamaway system shows these nice emoji to prevent spammers:

https://publiclab.org/signup?spamaway=true (if you're not logged in)

The code is here:

plots2/app/views/users/_spamaway.html.erb

Lines 19 to 21 in 3d74756

	<button type="button" class="col-xs-5 btn btn-default" style="font-size:3em;text-align:left;<% if i.odd? %> background:#eef;<% end %>" id="spamaway-<%= i.to_s + j.to_s %>">
	<%= spam.radio_button vars[i], statement %> <%= statement %>
	</button>

However, we're getting a warning now that since this is loaded multiple times per page, this segment is causing a collision of identical CSS ids:

I think we have to replumb it using classnames to get rid of this warning.

I /think/ we can potentially change these lines:

plots2/app/views/users/_spamaway.html.erb

Lines 19 to 21 in 3d74756

	<button type="button" class="col-xs-5 btn btn-default" style="font-size:3em;text-align:left;<% if i.odd? %> background:#eef;<% end %>" id="spamaway-<%= i.to_s + j.to_s %>">
	<%= spam.radio_button vars[i], statement %> <%= statement %>
	</button>

They're currently rendering like this, and you can see the id="spamaway_statement1_" that's causing the problem. But i think it may not be important to the functioning of the system, because the name field is the important part of a form. The

<button type="button" class="col-xs-5 btn btn-default" style="font-size:3em;text-align:left;" id="spamaway-00">
--
  | <input type="radio" value="📻" name="spamaway[statement1]" id="spamaway_statement1_" /> 📻
  | </button>

The above radio_button line is part of the form helpers in Rails: https://guides.rubyonrails.org/form_helpers.html

Can we maybe pass in something to the radio_button method to give a more unique id?

[divyabaid16]

Can I please work on this issue?

[GettyOrawo]

Hey @divyabaid16 there's this isuue that's already assigned to you. Mind if i work on this one?

[grvsachdeva]

hey @GettyOrawo, you can start working on this as @divyabaid16 has started with #4971 as per their comment . You both can also work on this together, totally up to you. Thanks!

[IshaGupta18]

How's the work going in on this one @GettyOrawo ? Checking in to see if you need any help!

[IshaGupta18]

Hey @GettyOrawo are you still working on this one?

[CleverFool77]

Hi Is this issue available @gauravano ?

[grvsachdeva]

yes @CleverFool77!

[CleverFool77]

I would like to work on this. @gauravano
thanks !!

[grvsachdeva]

Great!

[CleverFool77]

Hi @gauravano I opened a PR #5465 for this issue.
thanks !!!

[grvsachdeva]

Reviewing!!