Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notes ordering in recent notes #5360

Open
jainaman224 opened this issue Apr 3, 2019 · 12 comments

Comments

Projects
None yet
5 participants
@jainaman224
Copy link
Contributor

commented Apr 3, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/controllers/notes_controller.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -307,7 +307,7 @@ class NotesController < ApplicationController
     @wikis = Node.limit(10)
       .where(type: 'page', status: 1)
       .order('nid DESC')
-    @notes = Node.where(type: 'note', status: 1, created: Time.now.to_i - 1.weeks.to_i..Time.now.to_i)
+    @notes = Node.where(type: 'note', status: 1, created: Time.now.to_i - 1.weeks.to_i..Time.now.to_i).order(created: :desc)
     @unpaginated = true
     render template: 'notes/index'
   end
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@welcome

This comment has been minimized.

Copy link

commented Apr 3, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@jainaman224

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Order of notes should be descending according to date. It is ascending currently.
Screenshot 2019-04-03 at 10 02 41 PM

@namangupta01

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Nice catch 🎉 !

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@atjustbeinghumaid you can start working on this one. Thanks!

@gauravano gauravano added the assigned label Apr 3, 2019

@atjustbeinghumaid atjustbeinghumaid referenced this issue Apr 3, 2019

Merged

fixed-notes-ordering-in-recent-notes #1

1 of 5 tasks complete
@atjustbeinghumaid

This comment has been minimized.

Copy link

commented Apr 4, 2019

Why are the tests failing?
Can anybody help?

@jainaman224

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

Hey, Just create a PR. It is failing because PR is not created. Have a look at https://travis-ci.com/atjustbeinghumaid/plots2/builds/107054288#L4217.

@atjustbeinghumaid

This comment has been minimized.

Copy link

commented Apr 5, 2019

I have made a PR
Pls check and tell me if I have done it right
Suggestions are always welcome

@atjustbeinghumaid

This comment has been minimized.

Copy link

commented Apr 5, 2019

Just realized I made the changes in the master branch
Will create a descriptive branch name and do it again

@atjustbeinghumaid atjustbeinghumaid referenced this issue Apr 5, 2019

Open

fixed-notes-ordering-in-recent-notes #2

0 of 5 tasks complete
@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

Hey @atjustbeinghumaid, the above mentioned PR is open at your forked repo, not against publiclab/plots2.

Thanks!

@atjustbeinghumaid atjustbeinghumaid referenced a pull request that will close this issue Apr 7, 2019

Open

fixes notes ordering in recent notes #5393

5 of 5 tasks complete
@atjustbeinghumaid

This comment has been minimized.

Copy link

commented Apr 9, 2019

I have made a pr pls check it

@gauravano

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Hi @atjustbeinghumaid, you are required to attach the screenshot there, after installing the repo - #5393 (comment).

Thanks!

@AnshitaVishwa

This comment has been minimized.

Copy link

commented May 20, 2019

@gauravano and @jainaman224 I would like to work on this issue. can i continue with this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.