Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new question page (following style guide!) #6294

Closed
jywarren opened this issue Sep 14, 2019 · 14 comments · Fixed by #7034
Closed

Create new question page (following style guide!) #6294

jywarren opened this issue Sep 14, 2019 · 14 comments · Fixed by #7034
Labels
add-code-links design issue requires more design work and discussion (i.e. mockups and sketches) gci-candidate help wanted requires help by anyone willing to contribute medium for Google Code-In reserved-for-gci

Comments

@jywarren
Copy link
Member

#1994 describes the new design style guide, and we now have new designs for the basic Note and Wiki pages. But the Questions page is still looking a bit old. We should make the questions page use the same template as the notes page, so it is similarly cleaned up. We may need to preserve the "related questions" on the sidebar. But otherwise let's get it looking nice and minimal again!

We'd love help with this!

@jywarren jywarren added help wanted requires help by anyone willing to contribute design issue requires more design work and discussion (i.e. mockups and sketches) add-code-links labels Sep 14, 2019
@digitaldina

This comment has been minimized.

@jywarren
Copy link
Member Author

jywarren commented Sep 17, 2019

Please Note: We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more

Problem

Here, we're trying to work on the full question page itself - like at this URL:

https://publiclab.org/questions/adam-griffith/08-27-2019/favorite-camera-for-balloon-kite-mapping

image

See how it differs (not a huge amount, but in some key ways) from the basic notes page:

https://publiclab.org/notes/warren/08-27-2019/bringing-public-lab-s-multispectral-image-processing-to-leaflet-maps

image

The changes are pretty small, actually, just the header, really:

image

@jywarren

This comment has been minimized.

@jywarren jywarren added this to the User interface (UI) milestone Sep 27, 2019
@pydevsg

This comment has been minimized.

@jywarren

This comment has been minimized.

@pydevsg

This comment has been minimized.

@digitaldina digitaldina added gci-candidate medium for Google Code-In labels Oct 3, 2019
@digitaldina

This comment has been minimized.

@pydevsg

This comment has been minimized.

@publiclab publiclab deleted a comment from CleverFool77 Nov 15, 2019
@publiclab publiclab deleted a comment from pydevsg Nov 15, 2019
@SidharthBansal SidharthBansal changed the title new question page (following style guide!) Create new question page (following style guide!) Nov 15, 2019
@pydevsg
Copy link
Member

pydevsg commented Nov 21, 2019

Updated on GCI Dashboard

@SidharthBansal
Copy link
Member

Published

@Uzay-G
Copy link
Member

Uzay-G commented Dec 22, 2019

Hey @jywarren I was trying to look at how I could change the design and noticed that the question page sidebar is not placing itself next to the body of the question but instead it is placed after all the comments at the bottom of the page.

I don't have this problem on my local server so I used my devtools and noticed that this div of the application.html.erb file is somehow not a parent of the sidebar.


I'm not sure if this is an actual problem because the stable version of publiclab and my local server work fine so it's just the publiclab.org website.

A potential cause for this would be that an </div> tag was added somewhere that is closing the <div class="row"> too early.

@jywarren
Copy link
Member Author

jywarren commented Jan 3, 2020

Oof, those are the toughest type of HTML error to find. Can you confirm this is happening on all question pages, or is it possibly related to just that one page? Thanks!

@Uzay-G
Copy link
Member

Uzay-G commented Jan 4, 2020

Should I create an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-code-links design issue requires more design work and discussion (i.e. mockups and sketches) gci-candidate help wanted requires help by anyone willing to contribute medium for Google Code-In reserved-for-gci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants