Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space between image and header #6372

Open
samagragupta opened this issue Oct 2, 2019 · 11 comments

Comments

@samagragupta
Copy link
Member

commented Oct 2, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

Make some space between the image and header.
Like this:
Capture

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@welcome

This comment has been minimized.

Copy link

commented Oct 2, 2019

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@rimildeyjsr

This comment has been minimized.

Copy link

commented Oct 2, 2019

@samagragupta - Can I take this up?

@KMustakas88

This comment has been minimized.

Copy link

commented Oct 2, 2019

Hello, is there a PR for this already? I would like to contribute. @samagragupta @rimildeyjsr

@stefanosu

This comment has been minimized.

Copy link

commented Oct 2, 2019

Hi, I would like to contribute to this has this been claimed by someone else already? @samagragupta @rimildeyjsr

@aRealCyborg

This comment has been minimized.

Copy link

commented Oct 2, 2019

Is this already taken?

@aRealCyborg

This comment has been minimized.

Copy link

commented Oct 3, 2019

I need help to find out how to claim this issue or start working on the fix, This is my first time but I think I can do this. And should i use it in the Launcher

@aRealCyborg

This comment has been minimized.

Copy link

commented Oct 3, 2019

$FILENAME
I click on this and it does not give me a file or something you want to help fix

@CoderJolly

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@samagragupta - Can I take this up?

As @rimildeyjsr was the first one to comment, so the issue is assigned to @rimildeyjsr

@CoderJolly CoderJolly added the assigned label Oct 3, 2019
@profread

This comment has been minimized.

Copy link

commented Oct 3, 2019

hi has this been assigned to someone else

@rimildeyjsr

This comment has been minimized.

Copy link

commented Oct 4, 2019

@samagragupta @CoderJolly - Hey, just one question, the image above which space has to be created is the one referenced by main-image in the show.html.erb right?

Adding a top margin gets me this

Screenshot 2019-10-04 at 9 18 51 AM

Just want to make sure it is the correct image I am adding a margin above to 😅

@SerwaddaUG

This comment has been minimized.

Copy link

commented Oct 4, 2019

Hello here, i would like to contribute any information rendered will be of high appreciation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.