Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete alert text in app/views/like/_like.html.erb #7990

Closed
5 tasks
Tlazypanda opened this issue Jun 4, 2020 · 7 comments · Fixed by #7992
Closed
5 tasks

Update delete alert text in app/views/like/_like.html.erb #7990

Tlazypanda opened this issue Jun 4, 2020 · 7 comments · Fixed by #7992
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Tlazypanda
Copy link
Collaborator

Tlazypanda commented Jun 4, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/like/_like.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is the line which needs to be modified.

87 <a href='/notes/delete/<%= node.id %>' class='btn btn-outline-secondary btn-sm' id='menu-delete-btn' data-confirm='Are you sure?'> 

Replace this with the following line.

87 <a href='/notes/delete/<%= node.id %>' class='btn btn-outline-secondary btn-sm' id='menu-delete-btn' data-confirm='All revisions will be lost, and you cannot undo this action. If this is a spam page, be sure that it did not overwrite valid content before deleting the entire page and the history.'> 

Also modify the file test/system/post_test.rb
Line 216

216 accept_confirm "Are you sure?" do

Replace with

216 accept_confirm "All revisions will be lost, and you cannot undo this action. If this is a spam page, be sure that it did not overwrite valid content before deleting the entire page and the history." do
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Tlazypanda Tlazypanda added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Jun 4, 2020
@vinuch
Copy link
Contributor

vinuch commented Jun 4, 2020

Has someone claimed this issue? If not I’d like to handle it @Tlazypanda

@Tlazypanda
Copy link
Collaborator Author

Sure @vinuch Go ahead!! 🎉

@vinuch
Copy link
Contributor

vinuch commented Jun 5, 2020

i created a pull request but the travis build is failing and i have no idea why
screenshot of the error below
image

@adityakpranav
Copy link
Contributor

Hi @vinuch can i work on this issue??

@vinuch
Copy link
Contributor

vinuch commented Jun 5, 2020

@adityakpranav i have already worked on it i just cant tell why the travils build on the PR is failing
cc @Tlazypanda

@Tlazypanda
Copy link
Collaborator Author

Hey @vinuch Have left a comment for the pr ✌️

@adityakpranav Sorry this issue is already being worked on by @vinuch Let me try to find a fto issue for you 😅

@esiebomaj
Copy link
Member

Pls find an issue for me too
I want to contribute
@adityakpranav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants