Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date equality #441

Merged
merged 1 commit into from Feb 1, 2024
Merged

Fix date equality #441

merged 1 commit into from Feb 1, 2024

Conversation

mquandalle
Copy link
Collaborator

Fixes #430

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for publicodes-website ready!

Name Link
🔨 Latest commit 55ee9af
🔍 Latest deploy log https://app.netlify.com/sites/publicodes-website/deploys/65a8f87c5703e9000987756b
😎 Deploy Preview https://deploy-preview-441--publicodes-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@EmileRolley EmileRolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je dois avouer ne pas comprendre toutes les manipulations derrière convertToDate, cependant, vu la nature du changement ça à l'air de faire le taff pour ce cas là :)

Copy link
Member

@johangirod johangirod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@EmileRolley
Copy link
Collaborator

La gestion précise des dates et périodes n'étant pas triviale, pour Catala a été implémentée et formalisée : https://github.com/CatalaLang/dates-calc. Ca pourrait peut-être valoir le coup de l'utiliser ? (@denismerigoux qu'est-ce que tu en penses ?)

@denismerigoux
Copy link

Le papier associé à cette librairie vient de sortir d'ailleurs : https://rmonat.fr/data/pubs/2024/2024-04-08_esop_dates.pdf. Oui vous pouvez l'utiliser, soit en la compilant avec js_of_ocaml, soit en la portant vous-même en Javascript ou Typescript. À cette occasion faudra décider si vous voulez arrondir vos opérations sur les dates vers le haut ou vers le bas...

@mquandalle mquandalle merged commit 6bf8bf6 into master Feb 1, 2024
9 checks passed
@mquandalle mquandalle deleted the date-equality branch February 1, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L'égalité de dates ne fonctionne pas comme attendu
4 participants