Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a working test suite #11

Closed
gerv opened this issue Jul 9, 2015 · 8 comments
Closed

Make a working test suite #11

gerv opened this issue Jul 9, 2015 · 8 comments
Assignees

Comments

@gerv
Copy link
Contributor

gerv commented Jul 9, 2015

We should assemble the fragments of code in the tests/ directory into an actual runnable test suite which checks the file for common errors and makes it as unlikely as possible that we will break anyone's tree or parser.

This bug covers testing the things the existing tests cover. We should file additional bugs for other things we might like to test.

@weppos
Copy link
Member

weppos commented Jul 13, 2015

It probably makes sense. We just broke it a few days ago, a patch was merged today (#14).

@gerv any preference about the language? I may work on something, but I'm afraid my preferences may not meet yours or other devs.

I would most likely code something on Go or Ruby.

@gerv
Copy link
Contributor Author

gerv commented Jul 30, 2015

weppos: it needs to be something easily runnable on a variety of platforms. I'd prefer Python as many people know it, and the code won't be all that complex. But given that I don't have time to do it, I'd much rather you wrote it in Ruby than no-one wrote it :-)

@szepeviktor
Copy link

I suggest using Travis.

@malkusch
Copy link
Contributor

malkusch commented Aug 6, 2015

We just broke it a few days ago

You did it again (#21). +1 for CI (e.g. travis).

@szepeviktor
Copy link

There could be a regexp check for the list too.

  • stripping emty and comment line
  • ^\(\S\+\.)\+\S\+\$

@szepeviktor
Copy link

Please consider prepending this line to the tests:

{ echo '<?php '; cat tests/test_psl.txt; } | php -l || echo "Invalid code in text file."

@weppos weppos self-assigned this Jan 30, 2016
@weppos
Copy link
Member

weppos commented Jan 30, 2016

I prepared a preliminary test suite in #123. Feedback are welcome.

@weppos
Copy link
Member

weppos commented Mar 6, 2016

#123 was superseded by #130, which is now merged into master. A Makefile was added in #171 to run the tests locally using make test (or simply make).

@weppos weppos closed this as completed Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants