Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken test case c.il #21

Merged
merged 1 commit into from
Sep 7, 2015
Merged

fix broken test case c.il #21

merged 1 commit into from
Sep 7, 2015

Conversation

malkusch
Copy link
Contributor

@malkusch malkusch commented Aug 5, 2015

No description provided.

@szepeviktor
Copy link

Please consider prepending this line to the tests:

{ echo '<?php '; cat tests/test_psl.txt; } | php -l || echo "Invalid code in text file."

@malkusch
Copy link
Contributor Author

malkusch commented Aug 6, 2015

No, this PR is only for fixing the syntax error. What you suggest should go in something like a .travis file.

@szepeviktor
Copy link

Yes. Of-course.

@yaneti
Copy link

yaneti commented Aug 12, 2015

Any particular reason this hasn't been merged yet ?

@malkusch
Copy link
Contributor Author

let it brew a bit.

@szepeviktor
Copy link

An old PR has higher value?

@malkusch malkusch mentioned this pull request Aug 17, 2015
@yaneti yaneti mentioned this pull request Sep 1, 2015
gerv added a commit that referenced this pull request Sep 7, 2015
Fix broken test case (missing quote)
@gerv gerv merged commit 4fde644 into publicsuffix:master Sep 7, 2015
@gerv
Copy link
Contributor

gerv commented Sep 7, 2015

Sorry for the delay.

Gerv

@szepeviktor szepeviktor mentioned this pull request Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants