Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in using go modules #1897

Closed
aaomidi opened this issue Nov 18, 2023 · 2 comments
Closed

Interest in using go modules #1897

aaomidi opened this issue Nov 18, 2023 · 2 comments

Comments

@aaomidi
Copy link
Contributor

aaomidi commented Nov 18, 2023

As part of my work on #1894, I noticed that a lot of tooling I have at this point assumes everything uses go modules.

Are there any concerns about adding go modules as part of the generation code?

@cpu
Copy link
Contributor

cpu commented Nov 18, 2023

None from me, it's overdue 👍 There were some discussions where the need for it came up before.

I can't remember why it didn't start out as a module. Probably just due to the state of module support at the time the first version was written.

@weppos
Copy link
Member

weppos commented Nov 20, 2023

I can't remember why it didn't start out as a module. Probably just due to the state of module support at the time the first version was written.

Yes, most likely this is the scenario. I agree on bringing modules on, as long as they stay confined in the /tools folders and they don't leak outside in the root repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants