Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made a 404 page for publify with relevant links #623

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Made a 404 page for publify with relevant links #623

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44afbe1
changed navbar to dropdown onhover
Jun 25, 2015
2288cf6
added the missing bracket
Jun 25, 2015
7557c1c
redesigned 404 page
Jun 25, 2015
4435d5f
removed links
Jun 29, 2015
2702034
removed extra semicolon
Jun 29, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/assets/stylesheets/publify_admin.css.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@
*= require sidebar_admin
*= require datetimepicker
*/

.dropdown:hover .dropdown-menu { display: block; margin-top: 0; }
27 changes: 19 additions & 8 deletions public/404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<title>The page you were looking for doesn't exist (404)</title>
<title>404 Not Found</title>
<meta name="viewport" content="width=device-width,initial-scale=1">
<style>
body {
background-color: #EFEFEF;
background-color: #FFFFFF;
color: #2E2F30;
text-align: center;
font-family: arial, sans-serif;
Expand All @@ -23,7 +23,7 @@
border-right-color: #999;
border-left-color: #999;
border-bottom-color: #BBB;
border-top: #B00100 solid 4px;
border-top: #A5A5A5 solid 4px;
border-top-left-radius: 9px;
border-top-right-radius: 9px;
background-color: white;
Expand All @@ -32,9 +32,13 @@
}

h1 {
font-size: 100%;
color: #730E15;
line-height: 1.5em;
font-size: 42px;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an extra ; semi-colon here

color: #000000;
/*line-height: 1.5em;*/
}

h2 {
color: #417DBE;
}

div.dialog > p {
Expand All @@ -58,10 +62,17 @@
<!-- This file lives in public/404.html -->
<div class="dialog">
<div>
<h1>The page you were looking for doesn't exist.</h1>
<h2>Publify</h2>
<h1>404 Not Found</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having the <h2> and <h1> the other way around, <h1> then <h2>, to go semantically with heading hierarchy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 404 message is the main thing, so it makes sense for that to be h1. I would remove the Publify heading entirely.

<p>You may have mistyped the address or the page may have moved.</p>
</div>
<p>If you are the application owner check the logs for more information.</p>
<p>If you are the application owner check the logs for more information.
<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This <br> could be removed, unless you're using it to force an extra line

<br>
<a href="http://localhost:3000/">Home</a> |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link won't work in a production environment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll just remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky. You could simply change the links to just ba a path: /, /notes, and /archives, but in particular notes may not be relevant, and this will break if the blog is not located at the root of the web server.

Removing the links is probably the best option.

<a href="http://localhost:3000/notes">Notes</a> |
<a href="http://localhost:3000/archives">Archives</a>
</p>
</div>
</body>
</html>