Merge pull request #99 from publify/dependabot/bundler/rubocop-rspec-…

…tw-2.23.2

Update rubocop-rspec requirement from ~> 2.22.0 to ~> 2.23.2

publify_core.gemspec

@@ -60,7 +60,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rubocop-factory_bot", "~> 2.23.1"
   s.add_development_dependency "rubocop-performance", "~> 1.19.0"
   s.add_development_dependency "rubocop-rails", "~> 2.20.2"
-  s.add_development_dependency "rubocop-rspec", "~> 2.22.0"
+  s.add_development_dependency "rubocop-rspec", "~> 2.23.2"
   s.add_development_dependency "shoulda-matchers", "~> 5.3"
   s.add_development_dependency "simplecov", "~> 0.22.0"
   s.add_development_dependency "sqlite3", "~> 1.6"

spec/models/comment_spec.rb

@@ -152,8 +152,7 @@ def valid_comment(options = {})
 
     describe "with feedback moderation enabled" do
       before do
-        allow(blog).to receive(:sp_global).and_return(false)
-        allow(blog).to receive(:default_moderate_comments).and_return(true)
+        allow(blog).to receive_messages(sp_global: false, default_moderate_comments: true)
       end
 
       it "marks comment as presumably spam" do

spec/models/note_spec.rb

@@ -10,7 +10,7 @@
       it { expect(build(:note)).to be_valid }
       it { expect(build(:note).redirect).to be_blank }
       it { expect(create(:note).redirect).not_to be_blank }
-      it { expect(build(:note, body: nil)).to be_invalid }
+      it { expect(build(:note, body: nil)).not_to be_valid }
 
       it "with a nil body, return default error message" do
         note = build(:note, body: nil)
@@ -21,7 +21,7 @@
       context "with an existing note" do
         let(:existing_note) { create(:note) }
 
-        it { expect(build(:note, guid: existing_note.guid)).to be_invalid }
+        it { expect(build(:note, guid: existing_note.guid)).not_to be_valid }
       end
     end
 

spec/models/page_spec.rb

@@ -27,19 +27,19 @@
     context "with an existing page name" do
       let!(:page) { create(:page, name: "page_one") }
 
-      it { expect(build(:page, name: page.name)).to be_invalid }
+      it { expect(build(:page, name: page.name)).not_to be_valid }
     end
 
     context "without name" do
       it { expect(build(:page, name: nil)).to be_valid }
     end
 
     context "without body" do
-      it { expect(build(:page, body: nil)).to be_invalid }
+      it { expect(build(:page, body: nil)).not_to be_valid }
     end
 
     context "without title" do
-      it { expect(build(:page, title: nil)).to be_invalid }
+      it { expect(build(:page, title: nil)).not_to be_valid }
     end
   end