Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-rails requirement from ~> 2.20.2 to ~> 2.21.1 #105

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Update rubocop-rails requirement from ~> 2.20.2 to ~> 2.21.1 #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8808409
Update rubocop-rails requirement from ~> 2.20.2 to ~> 2.21.1
dependabot[bot] Sep 29, 2023
a98c1ad
Autocorrect Rails/FindEach offense
mvz Sep 29, 2023
13c7251
Autocorrect Rails/SelectMap offense
mvz Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/admin/articles_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def destroy
end

def auto_complete_for_article_keywords
@items = Tag.select(:display_name).order(:display_name).map(&:display_name)
@items = Tag.order(:display_name).pluck(:display_name)
render json: @items
end

Expand Down
2 changes: 1 addition & 1 deletion app/controllers/admin/post_types_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def destroy
# Reset all Articles from the PostType we're destroying to the default PostType
# Wrap it in a transaction for safety
@post_type.transaction do
Article.where(post_type: @post_type.permalink).each do |article|
Article.where(post_type: @post_type.permalink).find_each do |article|
article.post_type = "read"
article.save
end
Expand Down
2 changes: 1 addition & 1 deletion publify_core.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Gem::Specification.new do |s|
s.add_development_dependency "rubocop-capybara", "~> 2.19.0"
s.add_development_dependency "rubocop-factory_bot", "~> 2.24.0"
s.add_development_dependency "rubocop-performance", "~> 1.19.0"
s.add_development_dependency "rubocop-rails", "~> 2.20.2"
s.add_development_dependency "rubocop-rails", "~> 2.21.1"
s.add_development_dependency "rubocop-rspec", "~> 2.24.1"
s.add_development_dependency "shoulda-matchers", "~> 5.3"
s.add_development_dependency "simplecov", "~> 0.22.0"
Expand Down