Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series taxonomy template header and footer deprecated in FSE themes #409

Closed
htmgarcia opened this issue Feb 21, 2022 · 5 comments · Fixed by #620
Closed

Series taxonomy template header and footer deprecated in FSE themes #409

htmgarcia opened this issue Feb 21, 2022 · 5 comments · Fixed by #620

Comments

@htmgarcia
Copy link
Contributor

htmgarcia commented Feb 21, 2022

When Overview page is different to default for Twenty Twenty-Two theme, the front displays 2 deprecated errors:
Deprecated: Theme without header.php is <strong>deprecated</strong> since version 3.0.0 with no alternative available. Please include a header.php template in your theme. in /wp-includes/functions.php on line 5516

@htmgarcia htmgarcia added this to the 2.8.0: Design Improvements milestone Feb 21, 2022
@htmgarcia htmgarcia self-assigned this Feb 21, 2022
@htmgarcia htmgarcia changed the title Series taxonomy template header deprecated Series taxonomy template header and footer deprecated Feb 21, 2022
@htmgarcia
Copy link
Contributor Author

@htmgarcia htmgarcia changed the title Series taxonomy template header and footer deprecated Series taxonomy template header and footer deprecated in FSE themes Feb 21, 2022
@htmgarcia
Copy link
Contributor Author

htmgarcia commented Feb 21, 2022

@olatechpro we have a challenge for our custom templates on Twenty Twenty-Two and other themes with Full Site Editing support. get_footer() and get_header() are not supported.

@olatechpro
Copy link
Collaborator

@htmgarcia i just read the linked article and i think considering the fact this is new, maybe our best option may be rendering our custom templates for themes that support it pending the time there's a stable solution since block theme works differently.

I checked the documentation as well and rendering custom template may not be that easy but i'm still looking.

@olatechpro
Copy link
Collaborator

....on a further look, i don't think the way the new system is implemented, it may not be possible to render theme template in plugin. When i checked the Twenty Twenty-Two theme, the templating system has changed and even if we manage to find a way to render the default template in plugin, another check on another theme shows different themes template block data differs in implementation. Not sure if we'll find a solution anytime soon and in the meantime, maybe we can render the template for themes that support it ?

I don't really know what out best option will be here. @htmgarcia

@htmgarcia
Copy link
Contributor Author

We'll keep this on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment