Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make -f posix.mk clean target appears broken #108

Closed
mdegans opened this issue Jun 30, 2021 · 0 comments · Fixed by #145
Closed

make -f posix.mk clean target appears broken #108

mdegans opened this issue Jun 30, 2021 · 0 comments · Fixed by #145

Comments

@mdegans
Copy link

mdegans commented Jun 30, 2021 •
edited
Loading 

 $ make -f posix.mk clean
make -C posix -f posix.mk clean
make[1]: Entering directory '/home/anzu/Projects/c-core/posix'
rm pubnub_advanced_history_sample pubnub_sync_sample pubnub_sync_subloop_sample cancel_subscribe_sync_sample pubnub_sync_publish_retry pubnub_publish_via_post_sample pubnub_callback_sample pubnub_callback_subloop_sample subscribe_publish_callback_sample pubnub_fntest pubnub_console_sync pubnub_console_callback pubnub_sync.a pubnub_callback.a subscribe_publish_from_callback publish_callback_subloop_sample publish_queue_callback_subloop *.o *.dSYM
rm: cannot remove '*.dSYM': No such file or directory
posix.mk:190: recipe for target 'clean' failed
make[1]: *** [clean] Error 1
make[1]: Leaving directory '/home/anzu/Projects/c-core/posix'
posix.mk:13: recipe for target 'clean' failed
make: *** [clean] Error 2

Fix is to put a hyphen before rm

Would you accept a PR resolving the issue this way?
mdegans added a commit to mdegans/c-core that referenced this issue Jul 2, 2021
@mdegans
posix.mk: Fix clean target.
d62f73b 
This commit fixes the `clean` target failing when files aren't found.
A [suggestion from gnu.org](https://www.gnu.org/software/make/manual/html_node/Cleanup.html)
is used to resolve the matter.

Fixes `make -f posix.mk clean` target appears broken pubnub#108
@mdegans mdegans mentioned this issue Jul 2, 2021
Open
@Xavrax Xavrax mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(github-actions): migrate tests to GitHub Actions pubnub/c-core
1 participant
@mdegans