Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add publisher field in subscribe v2 message + fix region and flags fields #162

Merged
merged 7 commits into from
Jul 24, 2023
Merged

add publisher field in subscribe v2 message + fix region and flags fields #162

merged 7 commits into from
Jul 24, 2023

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Jul 20, 2023

feat: add publisher field in subscribe v2 message

Add publisher field into pubnub_v2_message

fix: fix flags and region values in subscribe v2 message

Fixed flags and region values that always equaled 0

budgetpreneur
budgetpreneur approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@budgetpreneur budgetpreneur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Xavrax
Copy link
Contributor Author

Xavrax commented Jul 24, 2023

@pubnub-release-bot release

@Xavrax Xavrax merged commit 70cf891 into master Jul 24, 2023
6 checks passed
@Xavrax Xavrax deleted the feature/get-publisher branch July 24, 2023 12:59
@pubnub-release-bot
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budgetpreneur budgetpreneur budgetpreneur approved these changes

@kleewho kleewho Awaiting requested review from kleewho

@parfeon parfeon Awaiting requested review from parfeon parfeon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Xavrax @pubnub-release-bot @budgetpreneur