Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide missing publish() function overload for qt #167

Merged
merged 6 commits into from
Nov 9, 2023

Conversation

Xavrax
Copy link
Contributor

@Xavrax Xavrax commented Nov 7, 2023

fix: Provide missing publish() function overload for QT wrapper

Provide missing publish() function overload for QT wrapper that allows set publish related options

Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change required and the rest is good!

qt/pubnub_qt.cpp Outdated Show resolved Hide resolved
Co-authored-by: Serhii Mamontov <parfeon@me.com>
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Xavrax
Copy link
Contributor Author

Xavrax commented Nov 8, 2023

@pubnub-release-bot release

@Xavrax Xavrax merged commit c1975f2 into master Nov 9, 2023
6 checks passed
@Xavrax Xavrax deleted the fix/missing-publish-fn branch November 9, 2023 18:28
@pubnub-release-bot
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants