Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features and improvements #53

Merged
merged 35 commits into from
Oct 16, 2018
Merged

Conversation

crimsonred
Copy link
Contributor

  • QueryParams in all API calls
  • d in grant
  • maxIdleConnsPerHost setting in config
  • Max concurrent workers for Publish and Grant requests

@pubnub pubnub deleted a comment Oct 15, 2018
@codecov-io
Copy link

Codecov Report

Merging #53 into master will decrease coverage by 1.05%.
The diff coverage is 68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   83.87%   82.81%   -1.06%     
==========================================
  Files          36       37       +1     
  Lines        3677     3829     +152     
==========================================
+ Hits         3084     3171      +87     
- Misses        502      580      +78     
+ Partials       91       78      -13
Impacted Files Coverage Δ
heartbeat_request.go 75% <0%> (-2.03%) ⬇️
unsubscribe_builder.go 62.5% <0%> (-14.43%) ⬇️
endpoints.go 93.54% <100%> (+0.44%) ⬆️
config.go 100% <100%> (ø) ⬆️
request.go 81.87% <100%> (+2.48%) ⬆️
publish_request.go 78.67% <100%> (+0.73%) ⬆️
clients.go 100% <100%> (ø) ⬆️
grant_request.go 97.65% <100%> (+7.21%) ⬆️
here_now_request.go 78.6% <16.66%> (-1.91%) ⬇️
subscribe_request.go 73.86% <16.66%> (-4.19%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e61f89...dd30271. Read the comment docs.

@crimsonred crimsonred merged commit 6484c15 into master Oct 16, 2018
@crimsonred crimsonred deleted the CE-3291-QueryParams-d-in-grant branch October 17, 2018 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants