Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat calls: new feature and optimizations #56

Merged
merged 28 commits into from
Dec 18, 2018

Conversation

crimsonred
Copy link
Contributor

Reduce heartbeats
Selective heartbeat to channels

@pubnub pubnub deleted a comment Dec 10, 2018
@pubnub pubnub deleted a comment Dec 10, 2018
@pubnub pubnub deleted a comment Dec 11, 2018
@pubnub pubnub deleted a comment Dec 12, 2018
@pubnub pubnub deleted a comment Dec 12, 2018
@pubnub pubnub deleted a comment Dec 12, 2018
@pubnub pubnub deleted a comment Dec 12, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #56 into master will decrease coverage by 1.58%.
The diff coverage is 56.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   82.81%   81.22%   -1.59%     
==========================================
  Files          37       39       +2     
  Lines        3829     3942     +113     
==========================================
+ Hits         3171     3202      +31     
- Misses        580      655      +75     
- Partials       78       85       +7
Impacted Files Coverage Δ
presence_request.go 0% <0%> (ø)
pubnub.go 80.1% <28.57%> (-2.12%) ⬇️
heartbeat_manager.go 75.18% <75.18%> (ø)
subscription_manager.go 75.42% <80%> (-2.75%) ⬇️
state_manager.go 66.66% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08735a5...015f715. Read the comment docs.

@pubnub pubnub deleted a comment Dec 17, 2018
@pubnub pubnub deleted a comment Dec 17, 2018
@crimsonred crimsonred merged commit 95eafa3 into master Dec 18, 2018
@crimsonred crimsonred deleted the CE-3315-Heartbeat-calls branch December 18, 2018 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants