Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow in IE11 when using "modern" library #16

Closed
nseegmiller opened this issue Oct 31, 2013 · 19 comments
Closed

Stack overflow in IE11 when using "modern" library #16

nseegmiller opened this issue Oct 31, 2013 · 19 comments
Assignees

Comments

@nseegmiller
Copy link

I've confirmed that this does not happen in IE 10, but I can reproduce it every time in IE11 (Win 8.1) using both the modern/pubnub.min.js and modern/pubnub.js. Here is the call stack from from the non-minified version.

screen shot 2013-10-31 at 11 08 34 am

@stephenlb
Copy link
Member

Hi! Thank you for the report. What version of the PubNub SDK is this on?

@nseegmiller
Copy link
Author

I first noticed the issue on 3.5.43. Downloaded the latest (3.5.47) and reproduced it there as well. Call stack shown above is on 3.5.47.

@stephenlb
Copy link
Member

Ty! I think this gives us details for now to start investigating further.

@ghost ghost assigned devendram Oct 31, 2013
@natebrunson
Copy link

I am also having this issue. Any word on what may be going on here?

bump

@stephenlb
Copy link
Member

Hi! Thank you for the error submission. What SDK version are you on?

@stephenlb
Copy link
Member

You may find it best to use the WEB SDK as a stopgap for now.

@geremyCohen
Copy link
Contributor

@natebrunson can you provide a code snippet that will help us reproduce the issue?

@natebrunson
Copy link

I am using modern/pubnub.min.js as of: d023d6f.

So let me try simply upgrading and using 3.5.48 and retest. Might be faster than whipping up some test code.

@natebrunson
Copy link

But it appears that nseegmiller said he tested it as recently as 3.5.47...

@geremyCohen
Copy link
Contributor

@natebrunson also as @stephenlb mentioned, let us know if the standard web versions exhibit the same issue for you. They are available here: https://github.com/pubnub/javascript/tree/master/web.

We'll be taking a look as well within the day, but if you find a workaround within https://github.com/pubnub/javascript/tree/master/web then its status-quo good news in the meantime :)

@stephenlb
Copy link
Member

@geremyCohen your github profile photo highlights your sense of technology knowledge and experience.

@nseegmiller
Copy link
Author

I just checked and my issue still exists in IE11 with modern, does not exist on IE10 with modern, and does not exist in IE11 with web. Just in case @natebrunson doesn't get you a small example of the modern problem, I'll try to come up with one. Currently it's pretty deeply integrated into our rather complex app, so it won't be trivial to create a simple version.

@geremyCohen
Copy link
Contributor

@nseegmiller thanks for helping us narrow this down. so it sounds like the web version is the workaround until we can get this straightened out.

@nseegmiller
Copy link
Author

Is the modern version available via CDN? I'm trying to build a codepen to demo the issue, but can't seem to find a direct link.

@stephenlb
Copy link
Member

Good question! We don't have the modern build on the CDN, as it isn't
all-encompassing like the Web build.

On Mon, Feb 24, 2014 at 4:11 PM, nseegmiller notifications@github.comwrote:

Is the modern version available via CDN? I'm trying to build a codepen to
demo the issue, but can't seem to find a direct link.


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-35959696
.

Cheers!
Stephen Blum - CTO
http://twitter.com/PubNub
https://github.com/pubnub/pubnub-api - GitHub
https://help.pubnub.com/ - Help Desk
www.pubnub.com
+1-425-830-6711

@nseegmiller
Copy link
Author

OK, I managed to reproduce it in a very simple example. I took the entire modern un-minified pubnub and just pasted it into codepen then added my very simple code at the bottom. This works fine in Chrome and throws the stack overflow in IE11. It is found here: http://codepen.io/nseegmiller/pen/lbIxv Let me know if I can help further.
screen shot 2014-02-24 at 5 40 54 pm

@stephenlb
Copy link
Member

try the following:

var pubnub = PUBNUB.init({
    windowing     : 1000,    // 1 SECOND
    publish_key   : 'demo',
    subscribe_key : 'demo'
})

@nseegmiller
Copy link
Author

You can see the updates in the pen I posted above. I altering the object as below (which was slightly different than what you mentioned due to the differences in the web and modern libraries):

var pubnubObject = PUBNUB({
subscribe_key: subscribeKey,
windowing: 1000
});

Got exactly the same results (stack overflow) in IE11. Feel free to fork my pen and test yourself if that helps.

@stephenlb
Copy link
Member

Thank you for the result. Must be another challenge in this case. Would be great to find the loop that is occurring on the modern version. For now make sure to use the web version.

ghost pushed a commit that referenced this issue Nov 18, 2021
Add ability to perform updates in public repository using `-nodeploy.#` tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants