-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v4.27.1 #187
Merged
Release v4.27.1 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add message actions Add Message Actions API support which allow to: add, remove and fetch previously added actions. feat: modify fetch messages endpoint to fetch message actions Add new arguments to fetch messages function which allow to fetch previously added actions and message metadata. feat: add new event handler for message actions Add new handler which can be used to track message actions addition / removal events.
New version release with Message Actions API support.
- David
- David
Make changes in fetch_messages endpoint to move message actions (if any) for message from 'data' to 'actions' property (old 'data' will be in place for few updates to not break existing clients). test: fix PAMv3 tests mocked signature Make sure, that we don't include dynamic 'pnsdk' into generated signature, so it won't break each time new version released. refactor: fix lint warnings for tests and code Make changes according to linter and flow checkers.
Make changes in fetch_messages endpoint to move message actions (if any) for message from 'data' to 'actions' property (old 'data' will be in place for few updates to not break existing clients). test: fix PAMv3 tests mocked signature Make sure, that we don't include dynamic 'pnsdk' into generated signature, so it won't break each time new version released. refactor: fix lint warnings for tests and code Make changes according to linter and flow checkers.
…e-variable fix(message-actions): move message actions to another variable
…-variable Fix fetchMessage action response and lint warnings
parfeon
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.