Migrate to SharedWorker
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `SharedWorker` instead of `Service Worker` for better PubNub client instances feedback. feat(shared-worker): add worker log verbosity flag Add configuration option to enable debug log output from the subscription `SharedWorker`. refactor: add declarations generation Create types declaration files.
parfeon
added
status: done
mohitpubnub
approved these changes
May 16, 2024
| sdkVersion: clientConfiguration.getVersion(), | ||
| logVerbosity: clientConfiguration.logVerbosity!, | ||
| workerLogVerbosity: platformConfiguration.subscriptionWorkerLogVerbosity!, |
There was a problem hiding this comment.
I'm assuming that platformConfiguration.subscriptionWorkerLogVerbosity will always hold non-null value right?
There was a problem hiding this comment.
@mohitpubnub yup, there are defaults applied when final platform-specific configuration created here.
| * Event signal shared worker client that worker can be used. | ||
| */ | ||
| export type SharedWorkerConnected = { | ||
| type: 'shared-worker-connected'; |
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(shared-worker): migrate to shared worker
Use
SharedWorkerinstead ofService Workerfor better PubNub client instances feedback.feat(shared-worker): add worker log verbosity flag
Add configuration option to enable debug log output from the subscription
SharedWorker.refactor: add declarations generation
Create types declaration files.