Logger invocations should use progname

[rhettc]

We use a consolidated logging 'system' so the ability to parse out one lib's messages from another is important to us. And while most of your messages start with Pubnub, not all do. That leaves me without a good way to isolate PubNub messages from others.

The Logger class has an alternate way to pass in the args when logging a message. Please consider invoking the logger methods in the way that includes program name (prognam). Extracting relevant bits from the stdlib docs below:

Signature:

info(progname, &block)

Arguments:

progname
In the block form, this is the progname to use in the log message.
block
Evaluates to the message to log. This is not evaluated unless the logger’s level is sufficient to log the message. This allows you to create potentially expensive logging messages that are only called when the logger is configured to show them.

$logger.debug('Pubnub::Client#start_subscribe | Override')
# could become
$logger.debug('PubNub'){'Pubnub::Client#start_subscribe | Override'}

http://ruby-doc.org/stdlib-2.1.1/libdoc/logger/rdoc/Logger.html#method-i-info

[blazeroot]

Hi @rhettc! Thanks for suggestion! I'm sure we will shortly refactor all .debug to pass progname parameter. I'll keep you updated here.

[rhettc]

Thanks @blazeroot, I look forward to it

[rhettc]

^ Ooops sorry about the state change. misclick!

[blazeroot]

Fixed in current develop, will be merged into master.