Event listener interface and presence changes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(presence-state): state maintained after set state is used `user_id` state for specified channels will be maintained by the SDK. State with subscribe calls has been improved. feat(api): adding first-class citizens to access subscription Adding `Channel`, `ChannelGroup`, `ChannelMetadata` and `UuidMetadata` entities to be first-class citizens to access APIs related to them. Currently, access is provided only for subscription APIs. feat(auto-retry): added ability to exclude endpoints from retry Added ability to configure request retry policies to exclude specific endpoints from retry.
parfeon
added
priority: medium
|
Adding PR for initial review purpose (interface shouldn't change) and documentation. There are still troubles with contract tests. |
Xavrax
reviewed
Jan 22, 2024
Xavrax
reviewed
Jan 23, 2024
Xavrax
reviewed
Jan 23, 2024
Xavrax
reviewed
Jan 23, 2024
Changes requested in review and changes in specs.
Added information about how `Subscription` and `SubscriptionSet` instance leaving the scope can affect subscription loop. refactor(presence): leave from all channels trigger different event Made changes which will trigger different event when unsubscribing from all channels and groups.
Make sure that `drop()` won't trigger `unregister` for `Subscription` and `SubscriptionSet` clones (which has been created with `Clone::clone()`).
Add new type to make it clear which parameters should be passed to `client.subscription(...)`.
|
@pubnub-release-bot release |
techwritermat
approved these changes
Jan 26, 2024
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(listener): change the real-time event handling interface
feat(presence-state): state maintained after set state is used
user_idstate for specified channels will be maintained by the SDK. State with subscribe calls has been improved.feat(api): adding first-class citizens to access subscription
Adding
Channel,ChannelGroup,ChannelMetadataandUuidMetadataentities to be first-class citizens to access APIs related to them. Currently, access is provided only for subscription APIs.feat(auto-retry): added ability to exclude endpoints from retry
Added ability to configure request retry policies to exclude specific endpoints from retry.