Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc_gateway rules don't work with 1.2 release of grpc-gateway #77

Closed
achew22 opened this issue Apr 5, 2017 · 1 comment
Closed

grpc_gateway rules don't work with 1.2 release of grpc-gateway #77

achew22 opened this issue Apr 5, 2017 · 1 comment

Comments

@achew22
Copy link
Contributor

achew22 commented Apr 5, 2017

Unfortunately I don't have time to fix this right now but it's almost certainly because of this commit. grpc-gateway switched to genproto for our proto-go files. The changes described in the makefile need to be made here as well before grpc-gateway 1.2 will work with rules_protobuf.
@pcj
Copy link
Contributor

pcj commented Apr 5, 2017

Thanks Andrew I'll take a look.

pcj added a commit that referenced this issue Apr 28, 2017
@pcj
Advance grpc_gateway support to 1.2
9eb0076 
* Adds new dependency on org_golang_go_genproto for pre-compiled google/api protos.
* Adds new dependency on a stripped copy of grpc_gateway for the actual google/api source protos.

Fixes #77
@pcj pcj mentioned this issue Apr 28, 2017
Merged
@pcj pcj closed this as completed in #95 Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achew22 @pcj