Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add 3rd party Apple tag source #795

Open
ajfersamad opened this issue Apr 17, 2023 · 1 comment
Open

Unable to add 3rd party Apple tag source #795

ajfersamad opened this issue Apr 17, 2023 · 1 comment
Labels
bug This is a bug, and should be fixed tag-sources Issues related to tags and tags sources

Comments

@ajfersamad
Copy link

ajfersamad commented Apr 17, 2023

Current Behavior

I am trying to add 3rd party tag source https://community.mp3tag.de/t/ws-apple-music/51184 to the puddletag. I followed your documentation. But getting this error.

---
aps@aps-lenovo:~/.config/puddletag/mp3tag_sources$ ll
total 40
drwxrwxr-x 2 aps aps  4096 Apr 17 11:16  ./
drwxrwxr-x 4 aps aps  4096 Apr 17 11:14  ../
-rw-r--r-- 1 aps aps   201 Apr 17 11:06 '&Apple Music#India (English).src'
-rw-r--r-- 1 aps aps   200 Dec 24 00:12 '&Apple Music#UAE (English).src'
-rw-r--r-- 1 aps aps 12197 Apr 17 11:13 'Apple Music Web.inc'
-rw-r--r-- 1 aps aps   357 Apr  6  2021 'iTunes API#India English.src'
-rw-rw-r-- 1 aps aps  4806 Apr 17 11:14 'iTunes Store.inc'
---
[2023-04-17 11:17:15,110]ERROR:Couldn't load Mp3tag Tag Source /home/aps/.config/puddletag/mp3tag_sources/&Apple Music#India (English).src
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/puddlestuff/webdb.py", line 94, in load_mp3tag_sources
    idents, search, album = mp3tag.open_script(f)
  File "/usr/lib/python3/dist-packages/puddlestuff/tagsources/mp3tag/__init__.py", line 122, in open_script
    idents, search, album = find_idents(f.readlines())
  File "/usr/lib/python3/dist-packages/puddlestuff/tagsources/mp3tag/__init__.py", line 109, in find_idents
    offset = album_source[0]
UnboundLocalError: local variable 'album_source' referenced before assignment
[2023-04-17 11:17:15,111]ERROR:Couldn't load Mp3tag Tag Source /home/aps/.config/puddletag/mp3tag_sources/iTunes API#India English.src
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/puddlestuff/webdb.py", line 94, in load_mp3tag_sources
    idents, search, album = mp3tag.open_script(f)
  File "/usr/lib/python3/dist-packages/puddlestuff/tagsources/mp3tag/__init__.py", line 122, in open_script
    idents, search, album = find_idents(f.readlines())
  File "/usr/lib/python3/dist-packages/puddlestuff/tagsources/mp3tag/__init__.py", line 109, in find_idents
    offset = album_source[0]
UnboundLocalError: local variable 'album_source' referenced before assignment
[2023-04-17 11:17:15,112]ERROR:Couldn't load Mp3tag Tag Source /home/aps/.config/p

Expected Behavior

The tag source works fine with MP3tag.

Steps To Reproduce

Try adding the tag source to puddletag

Information about your system

Puddletag: 2.2.0
OS: Ubuntu 22.04.2 LTS \n \l
Python: Python 3.10.6
PyQt:

Anything else?

No response

@ajfersamad ajfersamad added the bug This is a bug, and should be fixed label Apr 17, 2023
@corubba corubba added tag-sources Issues related to tags and tags sources bug This is a bug, and should be fixed and removed bug This is a bug, and should be fixed labels Apr 19, 2023
@sandrotosi
Copy link
Member

my first guess is the extra/uncommon characters may be the issue, @ajfersamad can you rename those files into something only using alphabet letters (maybe numbers and _-) and see if that works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is a bug, and should be fixed tag-sources Issues related to tags and tags sources
Projects
None yet
Development

No branches or pull requests

3 participants