-
-
Notifications
You must be signed in to change notification settings - Fork 298
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
20 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ef4cd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @pudo , just curious that why we add back OrderedDict here?
I saw the discussion on #47 and patch commit on 0726dd9 , but not very clear why we added this back, given the fact that OrderedDict is much slower than dict?
Thanks,
6ef4cd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I really can't remember, but I don't think that I am using the fact it's an ordered dict anywhere. Do you have a link re performance?
6ef4cd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, please see the performance review on http://stackoverflow.com/questions/19629682/ordereddict-vs-defaultdict-vs-dict
6ef4cd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably do the performance testing with OrderedDict vs. RowProxy instead of comparing with dicts, which don't expose the keys in order.
That being said, since RowProxy objects are having the decency of re-using a single list for storing (obviously identical) ordered keys for thousands of rows in a result I think it doesn't make much sense to cast to OrderedDicts.