-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR#1 of issue #2 #28
PR#1 of issue #2 #28
Conversation
- Fixed up the `AssignmentEnrollment` entity - Created `AssignmentEnrollmentRepository` - Created `AssignmentEnrollmentPage` model - added test data to `bootstrap_data.sql`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👌! Couple small changes that I forgot when I first worked on the class but really good 👍
src/main/java/com/unityTest/courseManagement/entity/AssignmentEnrollment.java
Outdated
Show resolved
Hide resolved
src/main/java/com/unityTest/courseManagement/entity/AssignmentEnrollment.java
Show resolved
Hide resolved
- Renamed the assignment associated with AssignmentEnrollment from "course" to "assignment - Added a JsonIgnore tag to the ID in AssignmentEnrollment - Added a USER_ID variable to bootstrap_data.sql for ease of testing - Added a 2 more test cases to Assignment enrolment in bootstrap_data
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
============================================
- Coverage 54.93% 54.66% -0.28%
- Complexity 139 140 +1
============================================
Files 46 47 +1
Lines 628 633 +5
Branches 19 19
============================================
+ Hits 345 346 +1
- Misses 270 274 +4
Partials 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet I'll merge this right away :)
Overview
Implement Assignment Enrollment
This change is a
Description
AssignmentEnrollment
entityAssignmentEnrollmentRepository
AssignmentEnrollmentPage
modelbootstrap_data.sql
Motivation/Links
#2
How was this tested?
The project runs without crashing, and the
AssignmentEnrollment
table shows up on H2 with the test data I added tobootstrap_data.sql
Todos
The rest of #2