PR#1 of issue #2 #28
Merged
PR#1 of issue #2 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed up the `AssignmentEnrollment` entity - Created `AssignmentEnrollmentRepository` - Created `AssignmentEnrollmentPage` model - added test data to `bootstrap_data.sql`
benjaminkostiuk
requested changes
Sep 27, 2021
src/main/java/com/unityTest/courseManagement/entity/AssignmentEnrollment.java
Outdated
Show resolved
Hide resolved
src/main/java/com/unityTest/courseManagement/entity/AssignmentEnrollment.java
Show resolved
Hide resolved
- Renamed the assignment associated with AssignmentEnrollment from "course" to "assignment - Added a JsonIgnore tag to the ID in AssignmentEnrollment - Added a USER_ID variable to bootstrap_data.sql for ease of testing - Added a 2 more test cases to Assignment enrolment in bootstrap_data
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
============================================
- Coverage 54.93% 54.66% -0.28%
- Complexity 139 140 +1
============================================
Files 46 47 +1
Lines 628 633 +5
Branches 19 19
============================================
+ Hits 345 346 +1
- Misses 270 274 +4
Partials 13 13
Continue to review full report at Codecov.
|
benjaminkostiuk
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement Assignment Enrollment
This change is a
Description
AssignmentEnrollmententityAssignmentEnrollmentRepositoryAssignmentEnrollmentPagemodelbootstrap_data.sqlMotivation/Links
#2
How was this tested?
The project runs without crashing, and the
AssignmentEnrollmenttable shows up on H2 with the test data I added tobootstrap_data.sqlTodos
The rest of #2