My greatest Jade fear has been realized :( #231

Closed
wavded opened this Issue Jun 1, 2011 · 9 comments

Comments

Projects
None yet
4 participants
Contributor

wavded commented Jun 1, 2011

I have a feeling this was recent:

These used to be interchangeable:

form(method:'post')

form(method='post')

But now it seems that : has gotten funky.

form(method:'post')

Gets translated to:

<form id="login" method:post="method:post">

I usually use : to indicate something that is not been computed, just a straight string or number and = to mean something that is computed like method= 'po' + 'st' (trite example I know). Is this a bug or is : getting phased out?

wavded closed this Jun 1, 2011

wavded reopened this Jun 1, 2011

Contributor

tj commented Jun 1, 2011

I recently removed ':' support so that namespaced keys can be used without lame quotes. I plan on adding it back as an option for those who use it a lot (including us). I wanted to get it out before 1.0

Contributor

TooTallNate commented Jun 1, 2011

Lol, quite a dramatic issue title!

Contributor

wavded commented Jun 1, 2011

Haha, yeah, was having a little fun! I previously had wondered if : was going away as I saw less and less examples using it. However I hope there is a way we can still use both, I personally like it over =.

Contributor

tj commented Jun 1, 2011

'=' always looked better to me since it's more like html, I would ditch the comma too if we didnt need the delimiter

Contributor

wavded commented Jun 1, 2011

matter of opinion I suppose, but this seems like a pretty big api switch for a minor version as most of my sites are broken now and have to be changed :(

Contributor

tj commented Jun 1, 2011

I can add the option for it

Contributor

tj commented Jun 1, 2011

we will 100% need it as well we have tons of jade and im pretty sure most of the files use ":"

wavded closed this Jun 1, 2011

wavded reopened this Jun 1, 2011

Contributor

wavded commented Jun 1, 2011

ahk :) I keep hitting the close issue button, to close the comment box :) this is an off day :) anyway, that would be super helpful to have that option in there.

pikeas commented Aug 14, 2011

Just hit this myself. Used Jade a few months ago, just grabbed a fresh install and all my old files are broken.

tj closed this in 6971206 Aug 14, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment