Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My greatest Jade fear has been realized :( #231

Closed
wavded opened this issue Jun 1, 2011 · 9 comments
Closed

My greatest Jade fear has been realized :( #231

wavded opened this issue Jun 1, 2011 · 9 comments

Comments

@wavded
Copy link
Contributor

wavded commented Jun 1, 2011

I have a feeling this was recent:

These used to be interchangeable:

form(method:'post')

form(method='post')

But now it seems that : has gotten funky.

form(method:'post')

Gets translated to:

<form id="login" method:post="method:post">

I usually use : to indicate something that is not been computed, just a straight string or number and = to mean something that is computed like method= 'po' + 'st' (trite example I know). Is this a bug or is : getting phased out?

@wavded wavded closed this as completed Jun 1, 2011
@wavded wavded reopened this Jun 1, 2011
@tj
Copy link
Contributor

tj commented Jun 1, 2011

I recently removed ':' support so that namespaced keys can be used without lame quotes. I plan on adding it back as an option for those who use it a lot (including us). I wanted to get it out before 1.0

@TooTallNate
Copy link
Contributor

Lol, quite a dramatic issue title!

@wavded
Copy link
Contributor Author

wavded commented Jun 1, 2011

Haha, yeah, was having a little fun! I previously had wondered if : was going away as I saw less and less examples using it. However I hope there is a way we can still use both, I personally like it over =.

@tj
Copy link
Contributor

tj commented Jun 1, 2011

'=' always looked better to me since it's more like html, I would ditch the comma too if we didnt need the delimiter

@wavded
Copy link
Contributor Author

wavded commented Jun 1, 2011

matter of opinion I suppose, but this seems like a pretty big api switch for a minor version as most of my sites are broken now and have to be changed :(

@tj
Copy link
Contributor

tj commented Jun 1, 2011

I can add the option for it

@tj
Copy link
Contributor

tj commented Jun 1, 2011

we will 100% need it as well we have tons of jade and im pretty sure most of the files use ":"

@wavded wavded closed this as completed Jun 1, 2011
@wavded wavded reopened this Jun 1, 2011
@wavded
Copy link
Contributor Author

wavded commented Jun 1, 2011

ahk :) I keep hitting the close issue button, to close the comment box :) this is an off day :) anyway, that would be super helpful to have that option in there.

@pikeas
Copy link

pikeas commented Aug 14, 2011

Just hit this myself. Used Jade a few months ago, just grabbed a fresh install and all my old files are broken.

@tj tj closed this as completed in 6971206 Aug 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants