Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test in latest release + master #2650

Closed
MylesBorins opened this issue Dec 22, 2016 · 4 comments
Closed

Failing test in latest release + master #2650

MylesBorins opened this issue Dec 22, 2016 · 4 comments

Comments

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 22, 2016 •
edited

This came up on CITGM. pug is currently failing a test on all platforms node is supported on

  241 passing (3s)
  1 failing

  1) test cases includes:

      AssertionError: expected '"<p>bar</p>\\n<body>\\n  <p>:)</p><script>\\n  console.log(\\"foo\\\\nbar\\")\\n</script>\\n  <script type=\\"text/javascript\\">var STRING_SUBSTITUTIONS = {    // table of character substitutions\\n  \'\\\\t\': \'\\\\\\\\t\',\\n  \'\\\\r\': \'\\\\\\\\r\',\\n  \'\\\\n\': \'\\\\\\\\n\',\\n  \'\\"\' : \'\\\\\\\\\\"\',\\n  \'\\\\\\\\\': \'\\\\\\\\\\\\\\\\\'\\n};\\n  </script>\\n</body>"' to be '"<p>bar</p>\\n<body>\\n  <p>:)</p><script>\\n  console.log(\\"foo\\\\nbar\\")\\n</script>\\n  <script type=\\"text/javascript\\">\\nvar STRING_SUBSTITUTIONS = {    // table of character substitutions\\n  \'\\\\t\': \'\\\\\\\\t\',\\n  \'\\\\r\': \'\\\\\\\\r\',\\n  \'\\\\n\': \'\\\\\\\\n\',\\n  \'\\"\' : \'\\\\\\\\\\"\',\\n  \'\\\\\\\\\': \'\\\\\\\\\\\\\\\\\'\\n};\\n\\n  </script>\\n</body>"'
      + expected - actual

      -"<p>bar</p>\n<body>\n  <p>:)</p><script>\n  console.log(\"foo\\nbar\")\n</script>\n  <script type=\"text/javascript\">var STRING_SUBSTITUTIONS = {    // table of character substitutions\n  '\\t': '\\\\t',\n  '\\r': '\\\\r',\n  '\\n': '\\\\n',\n  '\"' : '\\\\\"',\n  '\\\\': '\\\\\\\\'\n};\n  </script>\n</body>"
      +"<p>bar</p>\n<body>\n  <p>:)</p><script>\n  console.log(\"foo\\nbar\")\n</script>\n  <script type=\"text/javascript\">\nvar STRING_SUBSTITUTIONS = {    // table of character substitutions\n  '\\t': '\\\\t',\n  '\\r': '\\\\r',\n  '\\n': '\\\\n',\n  '\"' : '\\\\\"',\n  '\\\\': '\\\\\\\\'\n};\n\n  </script>\n</body>"

    at Assertion.fail (node_modules/should/cjs/should.js:231:17)
    at Assertion.value (node_modules/should/cjs/should.js:305:19)
    at Context.<anonymous> (test/run.js:82:42)
@MylesBorins
Copy link
Contributor Author

I found a commit that passed on travis --> https://travis-ci.org/pugjs/pug/jobs/181198360
The same commit is now failing. This leads me to believe that a breaking change may have been introduced by a dependency. Going to keep digging

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Dec 22, 2016 •
edited

Just dawned on me that ya'll started using a yarn lockfile for testing in CI. attempting to use yarn to install dependencies locally are not solving the problem, which is a little bit dis-concerning.

edit: ignore this... I was sent astray by the latest test run on jenkins... I can see ya'll are definitely do not have a lock file in the repo. Digging in more

@MylesBorins
Copy link
Contributor Author

Looks like this was in jstransformer-verbatim@1.1.0

going to bisect and find commit

@MylesBorins
Copy link
Contributor Author

Looks like there was a merge between branches on jstransformer-verbatim that made a change to behavior

I'm going to open an issue over there.

@MylesBorins MylesBorins mentioned this issue Dec 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MylesBorins