Ignore *lock file #2955
Merged
Ignore *lock file #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The project should work better if you use yarn instead of npm, since yarn's support for monorepos is much better. |
|
@ForbesLindesay yarn.lock is not in .gitignore, should we add it as well? |
|
Yes |
Merged
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After installing dependencies (npm@5.5.1) it automatically adds 'package-lock.json' file to each sub-project. I guess that we don't have lockfiles intentionally, so I asked git to ignore such files.
If that is not what we want, let's track lockfiles in git.