Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask-oidc expects the openid scope to be requested, but doesn't handle when it's not #30

Closed
jeremycline opened this issue Apr 24, 2017 · 0 comments
Closed

flask-oidc expects the openid scope to be requested, but doesn't handle when it's not #30

jeremycline opened this issue Apr 24, 2017 · 0 comments

Comments

@jeremycline
Copy link
Contributor

jeremycline commented Apr 24, 2017 •
edited
Loading

Flask-OIDC expects the id_token to not be None, but it will be None if the openid scope isn't requested.

No helpful exception is raised when this occurs (it results in a AttributeError since NoneType doesn't have get). It would be much better to explicitly handle the error and raise an exception notifying the developer of their error.
rockml pushed a commit to rockml/flask-oidc that referenced this issue Apr 21, 2019
@puiterwijk
Validate that the openid scope is always requested
cd69f5d 
Fixes: puiterwijk#30

Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremycline