Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark or System Default Android/Iphone mobile] Tray contents besides the title are not visible #344

Closed
christinach opened this issue Jul 3, 2024 · 2 comments · Fixed by #365
Closed

[Dark or System Default Android/Iphone mobile] Tray contents besides the title are not visible #344

christinach opened this issue Jul 3, 2024 · 2 comments · Fixed by #365
Assignees
@sandbergja @vh8154 @winsice-ng
Labels
bug Something isn't working
Milestone
AllSearch Go Live

Comments

@christinach
Copy link
Member

christinach commented Jul 3, 2024 •
edited
Loading

Expected behavior

I want to be able to view the all search website on my mobile when I switch in between different themes.

Actual behavior

Chrome settings when I select Dark mode or System Default, I can only see the Tray title not the tray details.

Steps to replicate

In an Android or Iphone mobile go to chrome settings and select 'dark' theme or 'system default'
go to https://allsearch.princeton.edu/?q=cat

Impact of this bug

E.g. "I can't work until this is fixed" or "I have a workaround"

Screenshots

allsearch results first screenshot
allsearch results second screenshot
@christinach christinach added the bug Something isn't working label Jul 3, 2024
@christinach christinach added this to the AllSearch Go Live milestone Jul 3, 2024
@christinach christinach changed the title [Dark or System Default Android mobile] Tray contents besides the title are not visible [Dark or System Default Android/Iphone mobile] Tray contents besides the title are not visible Jul 5, 2024
winsice-ng added a commit that referenced this issue Jul 5, 2024
@winsice-ng @sandbergja @vh8154
[#344] Added media queries for light and dark modes
661576c 
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>
vh8154 added a commit that referenced this issue Jul 5, 2024
@vh8154 @christinach
@sandbergja @maxkadel @winsice-ng
[#344] Add media queries to support dark and light mode in links.
54e71cd 
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
Co-authored-by: Winsice Ng <winsice-ng@users.noreply.github.com>
winsice-ng added a commit that referenced this issue Jul 5, 2024
@winsice-ng @christinach
@sandbergja @maxkadel @vh8154
[#344] Add media queries for dark and light mode for backgrounds
ddfd56b 
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>
@maxkadel maxkadel mentioned this issue Jul 8, 2024
Closed
2 tasks
@sandbergja
Copy link
Member

The rspec tests currently fail if you set your OS settings to dark mode. The success criteria for this one will be to make sure that these tests don't fail when the OS is set to dark mode.

winsice-ng added a commit that referenced this issue Jul 9, 2024
@winsice-ng @sandbergja @vh8154
[#344] Add media query to change link color for dark mode
1543e7b 
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>
@winsice-ng
Copy link
Contributor

We decided in conjunction with the AUX team to focus on meeting the accessibility requirements for dark mode. As a result, we added media queries related to dark mode such as changing text color for links and changing background colors. Additionally, we decided that future changes to the design in dark mode will be in a future ticket. 🍄 🍿 🌺

winsice-ng added a commit that referenced this issue Jul 9, 2024
@winsice-ng @sandbergja @vh8154
[#344] Fixed media query error
b330868 
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>
@winsice-ng winsice-ng mentioned this issue Jul 9, 2024
Merged
kevinreiss pushed a commit that referenced this issue Jul 9, 2024
@winsice-ng @sandbergja
@vh8154 @christinach @maxkadel
344 dark mode tray contents (#365)
a7a449c 
* [#344] Added media queries for light and dark modes

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>

* [#344] Add media queries to support dark and light mode in links.

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
Co-authored-by: Winsice Ng <winsice-ng@users.noreply.github.com>

* [#344] Add media queries for dark and light mode for backgrounds

Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>

* [#344] Add media query to change link color for dark mode

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>

* [#344] Fixed media query error

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>

---------

Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@users.noreply.github.com>
Co-authored-by: Vivian Ha <vh8154@princeton.edu>
Co-authored-by: Christina Chortaria <christinach@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
Co-authored-by: Winsice Ng <winsice-ng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandbergja sandbergja

@vh8154 vh8154

@winsice-ng winsice-ng

Labels
bug Something isn't working
Projects
None yet
Milestone
AllSearch Go Live
Development

Successfully merging a pull request may close this issue.

344 dark mode tray contents pulibrary/allsearch_frontend
4 participants
@sandbergja @christinach @vh8154 @winsice-ng