Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nodejs to 12.x #821

Closed
hackartisan opened this issue Aug 14, 2020 · 0 comments · Fixed by #825
Closed

Update Nodejs to 12.x #821

hackartisan opened this issue Aug 14, 2020 · 0 comments · Fixed by #825
Assignees
@hackartisan
Labels
dependencies Pull requests that update a dependency file
Projects
Maintenance Board

Comments

@hackartisan
Copy link
Member

@HackMasterA commented on Fri Aug 14 2020
@hackartisan hackartisan mentioned this issue Aug 14, 2020
Closed
@hackartisan hackartisan added this to To do in Maintenance Board via automation Aug 14, 2020
@hackartisan hackartisan added the dependencies Pull requests that update a dependency file label Aug 14, 2020
@hackartisan hackartisan moved this from To do to In progress in Maintenance Board Aug 17, 2020
@hackartisan hackartisan self-assigned this Aug 17, 2020
hackartisan added a commit that referenced this issue Aug 17, 2020
@hackartisan
Upgrade to node 12, just getting a new yarn.lock
165ac74 
fixes #821
@hackartisan hackartisan mentioned this issue Aug 17, 2020
Merged
hackartisan added a commit that referenced this issue Aug 17, 2020
@hackartisan
Upgrade to node 12, just getting a new yarn.lock
e80ba72 
fixes #821
@hackartisan hackartisan mentioned this issue Aug 17, 2020
Merged
eliotjordan added a commit to pulibrary/princeton_ansible that referenced this issue Aug 17, 2020
@eliotjordan
Merge pull request #1685 from pulibrary/dpul#821-node-12
88c7ae0 
DPUL upgrade nodejs to 12.x
Maintenance Board automation moved this from In progress to Done Aug 17, 2020
hackartisan added a commit that referenced this issue Aug 17, 2020
@hackartisan
Upgrade to node 12, just getting a new yarn.lock (#825)
6e00f03 
* Upgrade to node 12, just getting a new yarn.lock

fixes #821

* Use `lts/ebrium` instead of specific node version

This is because ansible grabs the latest release of the major version,
so we might fall behind in tests if we provision the server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hackartisan hackartisan

Labels
dependencies Pull requests that update a dependency file
Projects
Maintenance Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to node 12, just getting a new yarn.lock pulibrary/dpul
1 participant
@hackartisan