Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect tooltip test #1020

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix incorrect tooltip test #1020

merged 1 commit into from
Sep 29, 2021

Conversation

eliotjordan
Copy link
Member

Closes #1001

@tpendragon
Copy link
Contributor

I think this needs rebased? It's weird, the diff seems to include stuff that's merged from another PR.

@eliotjordan
Copy link
Member Author

@tpendragon I must have been moving too fast and branched from another branch rather than spotlight-upgrade. Rebased and ready for re-review.

hackartisan
hackartisan approved these changes Sep 29, 2021
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. I wonder how this passed before the upgrade.

@tpendragon tpendragon merged commit 8f3cd66 into spotlight-upgrade Sep 29, 2021
@tpendragon tpendragon deleted the 1001-tool-tip branch September 29, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan approved these changes

@tpendragon tpendragon tpendragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eliotjordan @tpendragon @hackartisan