Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpacker with Vite #1380

Merged
merged 9 commits into from Aug 12, 2022
Merged

Replace webpacker with Vite #1380

merged 9 commits into from Aug 12, 2022

Conversation

eliotjordan
Copy link
Member

Closes #1377

  • We had to ensure there were no lux tags around elements with javascript events bound to them.
  • Migrated local javascript to be served by Vite. Sprockets is still needed to serve upstream javascript.

@pulbot pulbot temporarily deployed to staging August 9, 2022 17:21 Inactive
@tpendragon
Copy link
Contributor

This works well for me.

Are we expecting any problems if Spotlight chooses a different packaging solution, and are comfortable switching to it if so?

Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add something to the readme about running bin/vite dev

@hackartisan
Copy link
Member

I updated the development documentation.

Re: spotlight decisions, I believe spotlight will have to make their javascript packages available via npm in order to participate in the current ecosystem. That said, if it turns out they do something that's incompatible with vite, we have discussed the possibility that we may need to move to a different tool and feel comfortable with that possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from webpacker
4 participants