New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace webpacker with Vite #1380
Conversation
So that it still gets regular click events
This works well for me. Are we expecting any problems if Spotlight chooses a different packaging solution, and are comfortable switching to it if so? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add something to the readme about running bin/vite dev
I updated the development documentation. Re: spotlight decisions, I believe spotlight will have to make their javascript packages available via npm in order to participate in the current ecosystem. That said, if it turns out they do something that's incompatible with vite, we have discussed the possibility that we may need to move to a different tool and feel comfortable with that possibility. |
Closes #1377