Merge pull request #886 from pulibrary/fix_tests

Fix instrumented adapter specs.
pulibrary · Mar 9, 2018 · 44e7206 · 44e7206
2 parents e2f6d25 + 6f1dcb6
commit 44e7206
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/app/adapters/instrumented_adapter.rb b/app/adapters/instrumented_adapter.rb
@@ -75,6 +75,13 @@ def find_by(id:)
       end
     end
 
+    def find_many_by_ids(ids:)
+      trace('valkyrie.find_many_by_ids') do |span|
+        span.set_tag('param.ids', ids.map(&:to_s))
+        __getobj__.find_many_by_ids(ids: ids)
+      end
+    end
+
     def find_all
       trace('valkyrie.find_all') do
         __getobj__.find_all

diff --git a/spec/adapters/instrumented_adapter_spec.rb b/spec/adapters/instrumented_adapter_spec.rb
@@ -29,10 +29,10 @@
       adapter.persister.save_all(resources: [output])
       adapter.query_service.find_by(id: output.id)
       adapter.query_service.find_all
-      adapter.query_service.find_members(resource: resource)
-      adapter.query_service.find_parents(resource: resource)
-      adapter.query_service.find_references_by(resource: resource, property: :member_ids)
-      adapter.query_service.find_inverse_references_by(resource: resource, property: :member_ids)
+      adapter.query_service.find_members(resource: output)
+      adapter.query_service.find_parents(resource: output)
+      adapter.query_service.find_references_by(resource: output, property: :member_ids)
+      adapter.query_service.find_inverse_references_by(resource: output, property: :member_ids)
       adapter.query_service.find_all_of_model(model: resource.class)
       adapter.persister.delete(resource: output)
       expect(tracer).to have_received(:trace).with("valkyrie.query").exactly(7).times