Merge pull request #320 from pulibrary/dont_error_displaying_thumbnails

Displaying thumbnail shouldn't fail on error.

app/helpers/osd_modal_helper.rb

@@ -32,6 +32,9 @@ def iiif_thumbnail_path(document, image_options = {})
     return if id.blank?
     thumbnail_document = Valkyrie.config.metadata_adapter.query_service.find_by(id: id)
     iiif_thumbnail_path(thumbnail_document, image_options)
+  rescue Valkyrie::Persistence::ObjectNotFoundError
+    Valkyrie.logger.warn "Unable to load thumbnail for #{document}"
+    nil
   end
 
   def build_thumbnail_path(id, image_options = {})

spec/helpers/osd_modal_helper_spec.rb

@@ -42,6 +42,12 @@
 
         expect(helper.figgy_thumbnail_path(parent_book)).to include file_set.id.to_s
       end
+      it "returns nothing when the fileset doesn't exist" do
+        book = FactoryGirl.create_for_repository(:scanned_resource, thumbnail_id: Valkyrie::ID.new("busted"))
+        parent_book = FactoryGirl.create_for_repository(:scanned_resource, thumbnail_id: book.id)
+
+        expect(helper.figgy_thumbnail_path(parent_book)).to eq nil
+      end
     end
   end
 end