Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all the appropriate fields to show view of Scanned Resources/Multi-Volume Works #20

Closed
tpendragon opened this issue Jul 28, 2017 · 0 comments · Fixed by #94
Closed

Add all the appropriate fields to show view of Scanned Resources/Multi-Volume Works #20

tpendragon opened this issue Jul 28, 2017 · 0 comments · Fixed by #94
Assignees
@jrgriffiniii
Labels
enhancement

Comments

@tpendragon
Copy link
Contributor

No description provided.

@escowles escowles added the ready label Aug 7, 2017
@jrgriffiniii jrgriffiniii changed the title Add all the appropriate fields to show view of SRs/MVWs Add all the appropriate fields to show view of Scanned Resources/Multi-Volume Works Aug 7, 2017
@jrgriffiniii jrgriffiniii self-assigned this Aug 7, 2017
@jrgriffiniii jrgriffiniii mentioned this issue Aug 8, 2017
Merged
jrgriffiniii added a commit that referenced this issue Aug 8, 2017
@jrgriffiniii
Resolves #20 and #7 by refactoring metadata within PlumSchema into th…
2c34528 
…e Schema:: Modules; Adds explicitly defined "suppressed" fields for decorated Valkyrie Resources

Migrating the refactored Schema Modules into the ImportedMetadata Class

Addressing styling rules and updating the RuboCops for the Schema Modules

Restructuring the attributes based upon their sources (where possible)

Tracking the new schema Modules

Excluding the Schema Modules from the coverage analysis

Extending the test suites for the schema Modules; Extending the test for the ScannedResource View displayed attributes

Resolving styling issues

Removing extraneous legacy attributes from being suppressed

Removing the unneeded Schema::Schema Module
@escowles escowles removed the Review label Aug 8, 2017
@jrgriffiniii jrgriffiniii reopened this Aug 8, 2017
@jrgriffiniii jrgriffiniii mentioned this issue Aug 9, 2017
Closed
@jrgriffiniii jrgriffiniii mentioned this issue Aug 9, 2017
Merged
jrgriffiniii added a commit that referenced this issue Aug 9, 2017
@jrgriffiniii
[WIP] Resolves #20 and #93 by delegating ScannedResourceDecorator acc…
961d170 
…essor methods to primary_imported_metadata (with the prefix "imported_") and explicitly exposing these prefixed values within "display_attributes"

Extending the test suite for the "show" View Template for ScannedResources for imported metadata; Ensuring that the necessary attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrgriffiniii jrgriffiniii

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renders imported metadata for ScannedResources pulibrary/figgy
3 participants
@escowles @jrgriffiniii @tpendragon