Extends IndexingAdapter to save metadata for member resources #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
reviewed
Aug 28, 2017
app/adapters/indexing_adapter.rb
Outdated
| @@ -41,7 +41,23 @@ def index_persister | |||
| # @note This saves into both the `persister` and `index_persister` | |||
| # concurrently. | |||
| def save(resource:) | |||
| composite_persister.save(resource: resource) | |||
| if resource.respond_to?(:member_ids) && !resource.member_ids.empty? | |||
There was a problem hiding this comment.
This should be part of PlumChangeSetPersister
jrgriffiniii
force-pushed
the
issues-83-jrgriffiniii-works-file-sets-visibility
branch
2 times, most recently
from
735b333
to
f7f0a40
Compare
jrgriffiniii
changed the title
escowles
reviewed
Aug 28, 2017
| @@ -52,6 +52,12 @@ def with(metadata_adapter:) | |||
| def before_save(change_set:) | |||
| apply_remote_metadata(change_set: change_set) | |||
| create_files(change_set: change_set) | |||
|
|
|||
| members(change_set: change_set).each do |member| | |||
| member.read_groups = change_set.read_groups | |||
There was a problem hiding this comment.
We should probably only do this if the read_groups or state have changed, otherwise, we'll be touching all the FileSets in a ScannedResource any time we make a metadata change.
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-83-jrgriffiniii-works-file-sets-visibility
branch
from
f7f0a40
to
3bc83a8
Compare
jrgriffiniii
changed the title
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-83-jrgriffiniii-works-file-sets-visibility
branch
from
3bc83a8
to
5ed12a9
Compare
…ess control permissions and state for member resources during a save Migrating the IndexingAdapter functionality for propagating visibility and state into the PlumChangeSetPersister Resolving styling issues Ensuring that visibility and state are only propagated if they are members of the ChangeSet Resolving issues for cases where ChangeSet attributes are not updated Extending the test case for when member works and file sets do not have their visibility and state update
jrgriffiniii
force-pushed
the
issues-83-jrgriffiniii-works-file-sets-visibility
branch
from
5ed12a9
to
ff7964d
Compare
jrgriffiniii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83 by extending the IndexingAdapter to propagate permissions and state for member resources during a save