Supports controlled vocabularies for Ephemera Projects #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
19c9cf9
to
7a78c51
Compare
jrgriffiniii
changed the title
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
7a78c51
to
d1c0c67
Compare
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
3 times, most recently
from
a88a5f1
to
f32af25
Compare
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
issues-168-jrgriffiniii-ephemera-models
branch
3 times, most recently
from
ff03858
to
00a2e31
Compare
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
2 times, most recently
from
d969f1c
to
4e5592c
Compare
jrgriffiniii
changed the base branch from
issues-168-jrgriffiniii-ephemera-models
to
master
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
d0ddd02
to
832fe90
Compare
…hemeraFolder resources within EphemeraProjects Adding routing and minimal support for EphemeraFolders Implementing a first attempt at supporting EphemeraBox membership and improving the routes for EphemeraBoxes and EphemeraFolders Ensuring that Resources can have IIIF Manifests exposed using the class method "can_have_manifests?"; Ensuring that EphemeraProjects and EphemeraBoxes are linked using the ContextualPath Implementing the attributes for the EphemeraFolders; Resolving issues for ScannedResources Integrating support for membership within EphemeraFolders Tracking files being merge after the latest rebase Adding the Factories and test suites for the Ephemera Decorators Extending the test coverage for the Ephemera* Controllers and Decorators Don't create a real property for append_id Append_id is a virtual property in Valkyrie that exists on ChangeSets. It's not something we want to persist - it's something we act on in a ChangeSetPersister. Extending the coverage for the Ephemera Decorators; Adding test coverage for the EphemeraBox and Folder ChangeSets Increasing the test coverage for EphemeraFolders and the ephemera editor role Clean up box show view. Ensures that IIIF Manifests are properly structured for EphemeraFolders Add Ephemera Folder Workflow Also DRYs this up a bit to make it easier to add another workflow later. Implementing the EphemeraVocabulary Class; Customizing and extending the View templates for EphemeraFields and EphemeraVocabulary objects Increasing the test coverage for Ephemera Vocabularies Extending the coverage for the EphemeraController Resolving a typo. error in the parent breadcrumbs partial Linking EphemeraFolders to vocabulary terms for EphemeraFields Ensures that errors encountered in EphemeraFields are handled properly Extending the coverage for Ephemera* Controllers and access permissions
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
3 times, most recently
from
f79795d
to
3fa33b0
Compare
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
3fa33b0
to
72678df
Compare
jrgriffiniii
changed the title
jrgriffiniii
changed the title
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
2 times, most recently
from
6e27059
to
30055b2
Compare
…eletion of EphemeraVocabulary and EphemeraTerm Objects Resolving breaking issues for form value submission (when fields are controlled); Resolving issues for when "edit" (rather than "new") EphemeraFolder forms are rendered Extending the coverage for the EphemeraTermDecorator Replacing the EphemeraVocabulary attribute "value" with "URI"; Ensuring that this is no longer required Remedying the test suites
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
30055b2
to
5ea5dd1
Compare
jrgriffiniii
changed the title
jrgriffiniii
changed the title
…ributes into Valkyrie::IDs Further extending the code coverage
jrgriffiniii
force-pushed
the
pull-189-jrgriffiniii-ephemera-fields
branch
from
880388c
to
d59eedc
Compare
jrgriffiniii
modified the milestones:
09/18/17 - 09/22/17 Sprint,
09/25/17 - 09/29/17 Sprint
jrgriffiniii
changed the title
|
I think there's some refactoring and generalizations we'll want to do soon, as well as some cleanup (if you delete a vocab it leaves a bunch of empty references), but for now I think we're good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #168 with the models for controlled vocabularies within Ephemera Projects