Add clipboard.js and use it for "copy to clipboard" button on auth_link #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hackartisan
force-pushed
the
2429-clipboard-button
branch
from
e47d7b4
to
5217ca7
Compare
hackartisan
changed the title
escowles
reviewed
Feb 4, 2019
|
|
||
| document.addEventListener('DOMContentLoaded', () => { | ||
| let div = document.getElementById('clipboard-trigger-holder') | ||
| div.innerHTML = '<button class="btn btn-primary" id="clipboard-trigger">Copy link to clipboard</button>' |
There was a problem hiding this comment.
Are you setting the button text here so it doesn't display if there's a problem loading the javascript? Or is there some other reason not to include in the view HTML?
There was a problem hiding this comment.
yeah, just sort of doing progressive enhancement I guess, since it only works if there's javascript.
escowles
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2429