Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable all Track detach buttons when one is clicked #2530

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

hackartisan
Copy link
Member

closes #2528

@hackartisan
Copy link
Member Author

screen shot 2019-02-05 at 1 10 11 pm

@christinach
Copy link
Member

why are we disabling all the Detach buttons and not only the one which is detached?

@hackartisan
Copy link
Member Author

@christinach the whole page reloads when you click a button. it's not really intended to support multiple detach actions at once.

@christinach
Copy link
Member

I understand. Thank you @HackMasterA . Maybe this is something that we can improve. -> not loading the whole page when detaching.

@hackartisan
Copy link
Member Author

@christinach for example, I just tried it with just disabling the one I click. I was able to click 3 buttons before the page reloaded, and see them all spin, but then when the reload came through, 2 of those had been removed and the 3rd was still there.

@hackartisan
Copy link
Member Author

Yes it would be nicer if it didn't reload on these actions. this was a quick/dirty implementation.

@tpendragon tpendragon merged commit f9b05d2 into master Feb 5, 2019
@tpendragon tpendragon deleted the 2528-disable-detach-buttons branch February 5, 2019 19:34
@tpendragon tpendragon removed the Review label Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable "detach" buttons after you click them in the Playlist members view.
4 participants